[enh]: Implement 'parity' intrinsic function #3662
Draft
+322
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxyd
commented
Mar 18, 2024
| parity_result_dim1 = parity(x, dim=1) | ||
| if (parity_result_dim1(1) .neqv. .TRUE.) error stop | ||
| if (parity_result_dim1(2) .neqv. .TRUE.) error stop | ||
| if (parity_result_dim1(3) .neqv. .FALSE.) error stop |
There was a problem hiding this comment.
I would've liked to compare all of the elements simultaneously, but it seems like it raises an error:
if (.NOT. ALL(parity(x, dim=1) .neqv. [.TRUE., .TRUE., .FALSE.])) then
error stop
end ifI believe it's unrelated to my changes, as the individual checks works without error. I didn't try to figure out why the above snippet wouldn't work.
Pranavchiku
reviewed
Mar 18, 2024
| @@ -703,6 +703,7 @@ RUN(NAME intrinsics_184 LABELS gfortran llvm) # selected_char_kind | |||
| RUN(NAME intrinsics_185 LABELS gfortran llvm) # verify | |||
| RUN(NAME intrinsics_186 LABELS gfortran llvm) # verify | |||
| RUN(NAME intrinsics_187 LABELS gfortran llvm) # popcnt | |||
| RUN(NAME intrinsics_parity LABELS gfortran llvm) | |||
There was a problem hiding this comment.
Suggested change
| RUN(NAME intrinsics_parity LABELS gfortran llvm) | |
| RUN(NAME intrinsics_188 LABELS gfortran llvm) #parity |
Let us maintain the convention here
Pranavchiku
reviewed
Mar 18, 2024
| @@ -0,0 +1,18 @@ | |||
| program intrinsics_parity | |||
There was a problem hiding this comment.
same here, program file_name
Pranavchiku
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parity GNU GCC docs