Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: Replace deprecated otelgrpc interceptors #7237

Closed
wants to merge 4 commits into from

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented Jan 3, 2024

This should stay in draft mode until this upstream bug is fixed.

Fixes #7235

@mcpherrinm
Copy link
Contributor

I think filtering healthchecks isn't actually that important, so it would be fine to merge this and have a tracking bug to filter them later. We can always drop them in the collector, if we need.

@pgporada
Copy link
Member Author

pgporada commented Apr 4, 2024

There's an open PR to add filtering, I'm inclined to let that play out and wait for a new otelgrpc version to be released.

@pgporada
Copy link
Member Author

The upstream PR has been merged, but we need to wait for a new otelhttp release to be cut. The existing version bump #7467 has problems, so :|.

@aarongable
Copy link
Contributor

aarongable commented May 20, 2024

#7467 has been merged, is this now ready to move forward again?

Answer: No, the release we updated to doesn't contain the relevant PR. We still need to wait for the next release.

@aarongable
Copy link
Contributor

Replaced by #7496

@aarongable aarongable closed this May 29, 2024
@aarongable aarongable deleted the replace-deprecated-otelhttp-interceptors branch May 29, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated otelgrpc interceptors with stats handler
3 participants