toLeopard: Strict number casting #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towerofnix
added
compatibility
towerofnix
added a commit
to towerofnix/sb-edit
that referenced
this pull request
Jul 2, 2024
This commit includes (or should include) all the same NaN-handling rules as researched and defined for pull request leopard-js#149, accounting for almost all new logic / line additions in this commit.
Not sure how we didn't catch this before.
Same as in leopard-js#150.
towerofnix
force-pushed
the
strict-number-casting
branch
from
385229a
to
1c1b95a
Compare
|
Note for reviewing: refer to #150 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123. Related to leopard-js/leopard-mentors#4 and #150.
This PR implements the proposal most particularly outlined in #123 (comment). It's intended as an alternative, and probably lesser, option, compared to the "traits" system outlined in - well, the same comment ✨ - and we'd like to have a go at implementing that one, before merging this. However, both PRs should be equally effective in generally fixing issues to do with surprise NaN in converted projects. (That being the case, behavior-testing projects are much needed.)
We haven't looked into it in great detail yet, but it appears to - more or less - fix the behavior of the case project (leopard-js/leopard-mentors#4), which has code that apparently sets sprite sizes to NaN.
This code is from December 2023 and we haven't made any significant edits except for rebasing it onto current master.