Defend renderer against NaN or non-number sprite size #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this prints the actual name of the sprite (or rather its constructor name), which should aid in identifying which sprites are broken, and tell that something's gone wrong with setting its size.
(WeakSet has similar browser support as WeakMap.)
|
I will be gone for a few days for the 4th of July so if @adroitwhiz is happy with this (or any other PR) feel free to merge. Otherwise I'll look into it when I return. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to leopard-js/leopard-mentors#4.
The main substantive change here is that
Renderer.renderSpritewill now always treat sprites with NaN or non-numbersizeas being 100%. This isn't "right" per se - "set size to NaN" is equal to "set size to 0" - but sprites should never be size NaN anyway, and I figure "treating as 100%" is more clearly-broken behavior than "treating as literally invisible". (Matching Scratch exactly would mean setting the size to the minimum valid size for that sprite's current costume, which the renderer isn't suited to handle on its own.)Secondary changes include warnings in the
SpeechBubbleSkin.getTextureandVectorSkin.getTextureinterfaces, which expect a non-NaN scale, and some light refactoring forVectorSkin._getMipmapandRenderer.renderSprite.This doesn't fix the case project (leopard-js/leopard-mentors#4), but it does clarify the error from a generic
WebGL: INVALID_VALUE: texImage2D: no canvasintoExpected a number, sprite TiledChevron size is NaN. Treating as 100%..