-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to exit with error instead of asking for interaction #712
base: main
Are you sure you want to change the base?
Conversation
@Rexios80 is attempting to deploy a commit to the FlutterTools Team on Vercel. A member of the Team first needs to authorize it. |
@Rexios80 Shouldn't this return a selection or default selection instead of just exiting? Also, we have added an |
The main user input I have issue with is the confirmation to install. The default value for that one is The isCI flag looks promising, but this tool isn't only meant for use in CI so that seems a little weird. |
I think I misread that you wanted to use the |
What do you mean "in favor of"? They're two completely separate PRs. |
The force flag also skips interaction. Which command do you need this no interaction for? |
Theoretically it could be any command that asks for interaction, but the biggest issue is when fvm asks to install a flutter version with |
@leoafarias What do we need to get this functionality in? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Rexios80 can you just update the docs on the website to document this flag? |
@leoafarias Before I do that are we sure we like the flag name "--no-interact"? I didn't put much thought into it and I don't want us to be stuck with something we don't like forever. |
Maybe "--no-input" would be better? Or even something like "--fvm-no-input" to guarantee it can't conflict with any dart/flutter flags? |
@leoafarias Please review this when you get a chance |
Fixes #710