feat: Don't proactively create the legacy fvm_config.json file
#668
Conversation
|
@mrgnhnt96 is attempting to deploy a commit to the FlutterTools Team on Vercel. A member of the Team first needs to authorize it. |
|
@mrgnhnt96 As much as I agree 100% with this PR, I can't bring it in as is.. The issue is that there is still CI/CD, that is dependent on this file, and the .fvm folder is ignored, so this file will not exist. Question: Does it matter to you if the file is automatically generated if the I think a solution would be to offer a "legacyConfig" flag on the project configuration, which allows for support of this fvm_config.json, or also do some type of CI/CD env var detection to create it. |
|
Hey @leoafarias! What exactly does the CI/CD depend on? Is it the flutter version? I don't really care if it is created since the directory is not checked to VC. It just seemed like a bug since |
This is on FVM's end, I am trying to figure out what could be causing this. |
|
Happy to take a look for you too if you need, just lmk |
Its solved for now... |
|
@mrgnhnt96, I will leave this open for now. We might have to put the legacy configuration generation behind a flag. But I am not 100% sure yet. |
Not a problem! Let me know if you have anything you'd like for me to help with |
I found that when I ran
fvm use stablethe legacyfvm_config.jsonwas created.This PR adds a check for if the legacy config file exists, then it can write to it. If it doesn't, it get skipped.
There was also a redundant check that I removed. Calling
file.write(...)will already check if the file exists and to create it if it doesn't.