Fix unsupervised fitting #21
Merged
+59
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows fitting unsupervised estimators with the assumption that they will always predict to shape (n_samples,). Output dtype is now determined based on the `_estimator_type` attribute. This is likely a temporary solution as `_estimator_type` is planned for deprecation in favor of tags and explicit estimator type checking functions, but neither of those solutions are fully implemented yet. See scikit-learn/scikit-learn#28960
grovduck
approved these changes
May 17, 2024
| y_pred = da.apply_gufunc( | ||
| estimator._wrapped.predict, | ||
| signature, | ||
| self.preprocessor.flat, | ||
| axis=self.preprocessor.flat_band_dim, | ||
| output_dtypes=[float], | ||
| output_dtypes=[output_dtype], |
There was a problem hiding this comment.
Nice, this fixes type for classifiers as well.
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
This fix allows fitting unsupervised estimators with the assumption that they will always predict to shape (n_samples,).
Output dtype is now determined based on the
_estimator_typeattribute. This is likely a temporary solution as_estimator_typeis planned for deprecation in favor of tags and explicit estimator type checking functions, but neither of those solutions are fully implemented yet.