Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve query param handling fixes #58 #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve query param handling fixes #58 #60

wants to merge 1 commit into from

Conversation

Andy2003
Copy link

@Andy2003 Andy2003 commented Oct 28, 2019 •
edited

improve query param handling fixes #58

@Andy2003 Andy2003 force-pushed the feature/improve-param-handling branch from e0e6bc2 to 0f15bcd Compare October 28, 2019 15:52
@Andy2003 Andy2003 force-pushed the feature/improve-param-handling branch from 0f15bcd to 8b87015 Compare January 25, 2020 23:35
@kaqqao kaqqao mentioned this pull request Jan 31, 2020
Open
@kaqqao
Copy link
Member

kaqqao commented Jan 31, 2020 •
edited

Sorry for the huge delay, and thanks a bunch for this!
Unfortunately, you introduced a direct dependency to Jackson which is problematic, as Jackson might not be available. Both SPQR and Spring work with other libraries and must adapt to whterever is configured.
A way to work around this is to abstract the deserialization either behind SPQR's own ValueMapper, or Spring's HttpMessageConverter (which is intended for parsing message bodies but can be abused for query params).
If you wish, I can take it over and make the changes to your branch (assuming you allowed me when making the PR), so that you commits stay. Or you can keep working on it? Ping me on Gitter if you wish to consult.

@Andy2003 Andy2003 force-pushed the feature/improve-param-handling branch 3 times, most recently from 2b29882 to 12bd514 Compare February 2, 2020 16:40
@Andy2003 Andy2003 requested a review from kaqqao February 2, 2020 16:41
@Andy2003 Andy2003 force-pushed the feature/improve-param-handling branch from 12bd514 to 2b8848f Compare August 15, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaqqao kaqqao Awaiting requested review from kaqqao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to GET request with variables
2 participants
@Andy2003 @kaqqao