Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated instructions and image of adapters #56

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

asubedy
Copy link
Member

@asubedy asubedy commented Jan 2, 2022

Signed-off-by: asubedy [email protected]

Description
Updated Instructions and images of adapters

This PR fixes #51

Notes for Reviewers
The PR is not completed yet, as of now Linkerd and NSM are updated. I will be updating the same after each adapter instructions are updated

Signed commits

  • Yes, I signed my commits.

@asubedy asubedy marked this pull request as draft January 2, 2022 11:01
@asubedy
Copy link
Member Author

asubedy commented Jan 6, 2022

NOTE: If you see a vim page please press q and y. Also if you see an error stating Failed to open Meshery in browser, please point your browser to.... please ignore it. To know that the Meshery has loaded with all the components connected, run mesheryctl system status{{execute}}. If all the components are in ready state you can open Mehsery UI tab with everything connected.

@leecalcote I am thinking of putting the above note(in this way itself) after the install command for this issue
I can not figure out any specific solution to avoid the vim mode. This small note can help people to continue with the instructions.

@asubedy asubedy marked this pull request as ready for review January 6, 2022 19:21
@asubedy
Copy link
Member Author

asubedy commented Jan 6, 2022

The last commit dealt with these changes:

  • Bumped Kubernetes version from 1.18 to 1.22
  • Updated instructions and Screenshots of Kuma adapter
  • Added a small note to help users to navigate on the katacoda terminal after the installation command
  • some minor screenshot updates on other adapters

Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @asubedy, just a nitpick could you please hyphenate the file name install image-hub.

"uilayout": "terminal-iframe"
},

"backend": {
"imageid": "kubernetes-cluster-running:1.18"
"imageid": "kubernetes-cluster-running:1.22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we took this image from the katacoda library, are you sure this works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was suggested by @piyushsingariya. And it is the only line of code I saw that mentioned the version of Kubernetes. So I guess it should work 🤞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be out of date, but here it is - https://www.katacoda.community/essentials/environments.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the docs only mention about 1.18 version. What should we do? The other adapters will work fine but OSM requires kubernetes >=1.19.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable OSM lab for some time until we figure some solution out and keep the other labs running with the Kubernetes version 1.18?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote @warunicorn19 thoughts on this approach?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think we should remove the OSM lab for the time being, since it doesn't work and I don't see a workaround either. @leecalcote ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trafeik-mesh adapter too. It's still not connecting after the install command.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that the OSM installations are working in the Meshery Adapter for OSM even on later K8s versions. @Aisuko, @Revolyssup, is it?

Meshery-Adapters/linkerd-meshery-adapter/step3.md Outdated Show resolved Hide resolved
Meshery-Adapters/linkerd-meshery-adapter/step3.md Outdated Show resolved Hide resolved
@leecalcote
Copy link
Member

@asubedy don't worry about DCO here. We'll get you covered.

@leecalcote
Copy link
Member

@Revolyssup, please track down the issue with OSM in the Meshery Adapter for OSM.

@leecalcote leecalcote added the area/lifecycle Lifecycle management (install, uninstall, configure) related label Jan 7, 2022
@leecalcote
Copy link
Member

@asubedy will you open an issue with adapter logs on meshery/meshery-osm repo?

@asubedy
Copy link
Member Author

asubedy commented Jan 7, 2022

@asubedy will you open an issue with adapter logs on meshery/meshery-osm repo?

How do I see the adapter logs? From the katacoda scenario or from my local machine?

Copy link

@helper-uttam helper-uttam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Revolyssup
Copy link

@Revolyssup, please track down the issue with OSM in the Meshery Adapter for OSM.

What's the issue with OSM adapter?

@asubedy
Copy link
Member Author

asubedy commented Jan 8, 2022

@Revolyssup, please track down the issue with OSM in the Meshery Adapter for OSM.

What's the issue with OSM adapter?

When trying to install OSM Servive mesh we get an error, that says we require Kubernetes version greater than or equal to 1.19. This is because on the lab we are using the pre runnung cluster version of 1.18. And there are no image of other version of kubernetes mentioned on the katacoda docs.

@stale
Copy link

stale bot commented Feb 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Feb 23, 2022
@asubedy asubedy added the issue/willfix This issue will be worked on label Feb 23, 2022
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Feb 23, 2022
@saurabh100ni
Copy link

This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lifecycle Lifecycle management (install, uninstall, configure) related issue/willfix This issue will be worked on
Development

Successfully merging this pull request may close these issues.

[WEBSITE] [LABS] Adapters name is not matching on various instructions
6 participants