Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #116 allow backup directory with spaces #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wikinaut
Copy link
Contributor

@Wikinaut Wikinaut commented May 9, 2018

@laurent22 here's a formal PR. Attention: I haven't tested it!

@laurent22
Copy link
Owner

laurent22 commented May 17, 2018

It seems the pull request sometimes adds two pairs of double quotes, and sometimes one pair of double and one pair single quotes. For example:

"\'$DEST_FOLDER/\'"

"\"$INPROGRESS_FILE\""

That would result in:

"'my/path'"

""my/path""

Is there any reason for this?

Edit: Sorry just saw you haven't tested it, but obviously this needs to be tested as we don't want to break people's backup scripts.

@ventoh
Copy link

ventoh commented Nov 22, 2018

+1. For me that has solved the problem. ( directory with spaces in destination backup dir)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants