Mobile: Share screen: Update headings and labels for consistency with desktop #10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
laurent22
reviewed
May 4, 2024
| @@ -64,7 +64,7 @@ const AcceptedShareItem: React.FC<Props> = props => { | |||
| } catch (error) { | |||
| logger.error('Failed to leave share', error); | |||
| await shim.showMessageBox( | |||
| _('Failed to leave share. Please verify that Joplin is connected to the internet and able to sync.\nError: %s', error), | |||
| _('Failed to leave shared notebook. Please verify that Joplin is connected to the internet and able to sync.\nError: %s', error), | |||
There was a problem hiding this comment.
Actually I think we should try to keep our error messages a bit simpler to make translation easier
Most of them will never be seen by the user and the error that was thrown should be sufficiently descriptive and if it's not that's when we start improving error messages.
But we should start with something simple, like I've done in the desktop implementation. Just Error: %s is enough most of the time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As requested elsewhere, this pull request updates the UI strings in the "accept share" screen to be closer to those used on desktop. As there is no analogous screen on desktop, with the exception of "leave notebook", the changed UI strings are still new.
Screenshot
Before:
After:
Other possibility
The below screenshot uses "New" and "Accepted" headers. While "Accepted" is a new string, "New" already has a translation.