feat: Add JavaScript code generation. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Apr 29, 2024
packages/javascript/src/codes.ts
Outdated
| * | ||
| * This function will automatically include the log code. | ||
| */ | ||
| export function configuration_usageWarning_proxyTlsAuth(): string { |
There was a problem hiding this comment.
I went with a less-elegant code generation style. The nested static classes and methods had a nice interface, but were not suitable for client-side JS because they cannot be tree shaken.
Making each export a function should result in optimal tree-shaking or client-side SDKs.
kinyoklion
commented
Apr 29, 2024
| @@ -0,0 +1 @@ | |||
| tool/ | |||
There was a problem hiding this comment.
We don't need to publish the tool source to the package.
cwaldren-ld
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add javascript code generation and package definition.
Should be reviewed after scaffold PR.