Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tvOS target #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add tvOS target #151

wants to merge 1 commit into from

Conversation

todorone
Copy link

@todorone todorone commented Sep 7, 2022

We successfully use LaunchDarkly SDK for tvOS platform, it's fully compatible. This change is the only thing that is required for successful compilation.

@louis-launchdarkly
Copy link
Contributor

Hello @todorone, thank you for the contribution! Because LaunchDarkly React Native SDK uses the LaunchDarkly iOS SDK as the native module for iOS (which supports tvOS), it is good that this works out for you.

We will discuss this with the React Native and iOS engineers, and if it makes sense, port the test (https://app.circleci.com/pipelines/github/launchdarkly/ios-client-sdk/95/workflows/74b1aea7-374f-425f-9a6f-8288b16e6cd3/jobs/635) into React Native SDK and accept the change.

@todorone
Copy link
Author

Hello @todorone, thank you for the contribution! Because LaunchDarkly React Native SDK uses the LaunchDarkly iOS SDK as the native module for iOS (which supports tvOS), it is good that this works out for you.

We will discuss this with the React Native and iOS engineers, and if it makes sense, port the test (https://app.circleci.com/pipelines/github/launchdarkly/ios-client-sdk/95/workflows/74b1aea7-374f-425f-9a6f-8288b16e6cd3/jobs/635) into React Native SDK and accept the change.

thanks a lot, @louis-launchdarkly

what is approximate timeline for this - days, months, years, centuries? 😸

LaunchDarklyReleaseBot pushed a commit that referenced this pull request Mar 15, 2023
* fix: startup crash due to missing proguard file

* Add Todd to codeowners

* update pods

* add separate android-release command

---------

Co-authored-by: Yusinto Ngadiman <[email protected]>
yusinto added a commit that referenced this pull request Mar 15, 2023
* [sc-192324] Fix jsonVariation bug (#150)

Update LaunchdarklyReactNativeClient.swift

Co-authored-by: Yusinto Ngadiman <[email protected]>

* Add 6.x branch

* fix: startup release build crash (#151)

* fix: startup crash due to missing proguard file

* Add Todd to codeowners

* update pods

* add separate android-release command

---------

Co-authored-by: Yusinto Ngadiman <[email protected]>

---------

Co-authored-by: Yusinto Ngadiman <[email protected]>
Co-authored-by: Yusinto Ngadiman <[email protected]>
Co-authored-by: LaunchDarklyReleaseBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants