Modify Provider to keep the latest flags even when it is remounted #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufferings
requested review from
kinyoklion,
yusinto and
louis-launchdarkly
as code owners
yusinto
requested changes
Mar 14, 2024
src/asyncWithLDProvider.tsx
Outdated
Comment on lines
43
to
44
| const initialFlags = options?.bootstrap && options.bootstrap !== 'localStorage' ? options.bootstrap : fetchedFlags; | ||
| let currentFlags = initialFlags; |
There was a problem hiding this comment.
We can just re-use the initialFlags variable for this purpose:
Suggested change
| const initialFlags = options?.bootstrap && options.bootstrap !== 'localStorage' ? options.bootstrap : fetchedFlags; | |
| let currentFlags = initialFlags; | |
| let initialFlags = options?.bootstrap && options.bootstrap !== 'localStorage' ? options.bootstrap : fetchedFlags; |
There was a problem hiding this comment.
Thank you for your suggestion! After I changed to use initialFlags, I felt the variable was no longer initial. So I tried to use currentFlags. Please could you have a look at it? If it's better to use initialFlags instead of currentFlags or any better names, please let me know and I would change it.
Comment on lines
+48
to
+49
| unproxiedFlags: currentFlags, | ||
| ...getFlagsProxy(ldClient, currentFlags, reactOptions, targetFlags), |
There was a problem hiding this comment.
Suggested change
| unproxiedFlags: currentFlags, | |
| ...getFlagsProxy(ldClient, currentFlags, reactOptions, targetFlags), | |
| unproxiedFlags: initialFlags, | |
| ...getFlagsProxy(ldClient, initialFlags, reactOptions, targetFlags), |
src/asyncWithLDProvider.tsx
Outdated
Comment on lines
57
to
58
| const updatedUnproxiedFlags = { ...unproxiedFlags, ...updates }; | ||
| currentFlags = updatedUnproxiedFlags; |
There was a problem hiding this comment.
Suggested change
| const updatedUnproxiedFlags = { ...unproxiedFlags, ...updates }; | |
| currentFlags = updatedUnproxiedFlags; | |
| initialFlags = { ...unproxiedFlags, ...updates }; |
src/asyncWithLDProvider.tsx
Outdated
| @@ -54,6 +55,7 @@ export default async function asyncWithLDProvider(config: AsyncProviderConfig) { | |||
| if (Object.keys(updates).length > 0) { | |||
| setLDData(({ unproxiedFlags }) => { | |||
| const updatedUnproxiedFlags = { ...unproxiedFlags, ...updates }; | |||
| currentFlags = updatedUnproxiedFlags; | |||
|
|
|||
| return { | |||
| unproxiedFlags: updatedUnproxiedFlags, | |||
There was a problem hiding this comment.
Replace updatedUnproxiedFlags with initialFlags in the return object:
Suggested change
| unproxiedFlags: updatedUnproxiedFlags, | |
| unproxiedFlags: initialFlags, | |
| ...getFlagsProxy(ldClient, initialFlags, reactOptions, targetFlags), |
Co-authored-by: Yusinto Ngadiman <[email protected]>
Co-authored-by: Yusinto Ngadiman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
#237
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.