feat(icons): add holdout icon #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaija
requested review from
matthewferry,
antonio-darkly and
a team
as code owners
🦋 Changeset detectedLatest commit: 0fd639b The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +2.77 kB (+1.39%) Total Size: 202 kB
ℹ️ View Unchanged
|
pheggeseth
reviewed
May 14, 2024
packages/icons/src/img/sprite.svg
Outdated
| @@ -1983,5 +1983,10 @@ | |||
| clip-rule="evenodd" | |||
| /> | |||
| </symbol> | |||
| <symbol viewBox="0 0 20 20" id="lp-icon-holdout"> | |||
There was a problem hiding this comment.
It would be awesome if you'd be willing to put this icon in alphabetical order like the rest of them! 🙏🏻
There was a problem hiding this comment.
Oh sorry about that, I will move into the correct order!
pheggeseth
approved these changes
May 14, 2024
matthewferry
approved these changes
May 14, 2024
There was a problem hiding this comment.
Some nits
- move holdout symbol to alphabetical
- each attribute should be on its own line if there are more than 1 (wish our prettier implementation just fixed this for you 😿 )
The svg path looks to be just a touch off-center. not a huge deal, but ideally you can swap the path definition for:
<symbol viewBox="0 0 20 20" id="lp-icon-holdout">
<path
fill-rule="evenodd"
d="M13.75 9.984a1.15 1.15 0 1 0 0 2.3 1.15 1.15 0 0 0 0-2.3Zm-2.65 1.15a2.65 2.65 0 1 1 5.3 0 2.65 2.65 0 0 1-5.3 0Z"
clip-rule="evenodd"
/>
<path d="M9.917 14.067a2.4 2.4 0 1 1-4.8 0 2.4 2.4 0 0 1 4.8 0Z"/>
<path
fill-rule="evenodd"
d="M6.75 4.984a1.65 1.65 0 1 0 0 3.3 1.65 1.65 0 0 0 0-3.3ZM3.6 6.634a3.15 3.15 0 1 1 6.3 0 3.15 3.15 0 0 1-6.3 0Z"
clip-rule="evenodd"
/>
</symbol>
|
@matthewferry @pheggeseth Thanks so much yall for reviewing, I moved the svg up to the correct order and swapped the path definition ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the new icon 'holdout'. It will be used to represent a holdout object in the experimentation product.
Screenshots (if appropriate):
Testing approaches