Avoid exposing LDSwiftEventSource as dependency, when building xcframework #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Due to some users can't using public SPM on GitHub, using pre-build binary xcframework is a good option. But at the source code, using
import LDSwiftEventSource
will expose it as another dependency(bothLaunchDarkly.xcframework
andLDSwiftEventSource.xcframework
) which isn't necessary.Potential related issue: #257
Describe the solution you've provided
Solution👉 Mark
LDSwiftEventSource
as @ _implementationOnly will prevent it from expose as dependency: it'll remove LDSwiftEventSource from the final .swiftinterface file