Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ANSI functions explicitly #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use ANSI functions explicitly #85

wants to merge 1 commit into from

Conversation

computerquip-work
Copy link

@computerquip-work computerquip-work commented May 17, 2024 •
edited

A simple attempt at fixing the issues with UNICODE. I've not removed the countermeasures already implemented.

Work towards: #84

@laudrup
Copy link
Owner

laudrup commented May 19, 2024

Looks like how this should have been done initially. Thanks a lot.

If you remove the ugly #ifdef UNICODE stuff I had written initially I think this could be merged.

There's already a job for testing with UNICODE defined. You might consider extending that so it fails with the current implementation (ie. the headers are included with UNICODE defined before including wintls) but it's not all that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@computerquip-work @laudrup