Fix get_prompt_template() for parameterized_model_parser
#878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting this error: ``` Exception: Cannot get prompt template string from prompt input: attachments=[Attachment(data='https://s3.amazonaws.com/lastmileai.aiconfig.public/uploads/2024_1_10_18_41_31/1742/bear_with_honey.png', mime_type='image/png', metadata=None), Attachment(data='https://s3.amazonaws.com/lastmileai.aiconfig.public/uploads/2024_1_10_18_41_31/7275/fox_in_forest.png', mime_type='image/png', metadata=None)] data=None ``` When Sarmad did this fix in #866, he missed a callsite in the `parameterized_model_parser`. This was missed because at the time the image_2_text model parser was of type `ModelParser` instead of `ParameterizedModelParser`, which had to be converted in here to fix a bug: #877 ## Test Plan Before <img width="1295" alt="Screenshot 2024-01-11 at 02 52 42" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/c0c99f1e-2996-41f3-8274-c13ecc43f07e"> After https://github.com/lastmile-ai/aiconfig/assets/151060367/7a10932c-8580-4584-8942-4c287f23fc82
rossdanlm
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile and
jonathanlastmileai
as code owners
saqadri
reviewed
Jan 11, 2024
| return prompt.input.data | ||
| else: |
There was a problem hiding this comment.
I left this in intentionally here. Because if a model parser says it's parameterized and we fail to resolve its prompt template, then we should throw an exception.
There was a problem hiding this comment.
That's perfect thanks!
|
Sorry I forgot to delete this. Shouldn't be useful anymore after #881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
get_prompt_template()for parameterized_model_parserGetting this error:
When Sarmad did this fix in #866, he missed a callsite in the
parameterized_model_parser. This was missed because at the time the image_2_text model parser was of typeModelParserinstead ofParameterizedModelParser, which had to be converted in here to fix a bug: #877Test Plan
Before
After
Screen.Recording.2024-01-11.at.02.55.07.mov
Stack created with Sapling. Best reviewed with ReviewStack.
get_prompt_template()for parameterized_model_parser #878