Add model setting completion params for Image2Text prompt schema #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSIA, pretty simple actually ## Test Plan Follow the README from AIConfig Editor https://github.com/lastmile-ai/aiconfig/tree/main/python/src/aiconfig/editor#dev, then run these commands: Make sure also that you don't have the `python-aiconfig-test` installed: `pip3 uninstall python-aiconfig-test` ```bash aiconfig_path=/Users/rossdancraig/Projects/aiconfig/cookbooks/Gradio/huggingface.aiconfig.json parsers_path=/Users/rossdancraig/Projects/aiconfig/cookbooks/Gradio/hf_model_parsers.py alias aiconfig="python3 -m 'aiconfig.scripts.aiconfig_cli'" aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path ``` <img width="1261" alt="Screenshot 2024-01-11 at 01 21 21" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/63ef4830-1163-4229-90ea-d49b914d1ec2">
rossdanlm
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile and
jonathanlastmileai
as code owners
saqadri
approved these changes
Jan 11, 2024
| "audio/webm", | ||
| "audio/flac", | ||
| "audio/ogg", | ||
| "audio/ogg", |
There was a problem hiding this comment.
This looks duplicated. Error?
There was a problem hiding this comment.
It's just auto-formatting when I hit the CMD + S
| type: "number", | ||
| description: `The maximum numbers of tokens to generate, ignoring the number of tokens in the prompt` | ||
| } | ||
| type: "integer", |
There was a problem hiding this comment.
Because number is a float while integer is an integer value. I think this was incorrectly transcribed the first time
| type: "number", | ||
| description: `The maximum time in seconds to wait for fetching images | ||
| from the web. If None, no timeout is set and the call may block forever.`, | ||
| }, |
There was a problem hiding this comment.
Oh wow that's a short list of possible params
There was a problem hiding this comment.
yea it's actually pretty wild. It's why I left a comment about it in in summary for #855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add model setting completion params for Image2Text prompt schema
TSIA, pretty simple actually
Test Plan
Follow the README from AIConfig Editor https://github.com/lastmile-ai/aiconfig/tree/main/python/src/aiconfig/editor#dev, then run these commands:
Make sure also that you don't have the
python-aiconfig-testinstalled:pip3 uninstall python-aiconfig-testStack created with Sapling. Best reviewed with ReviewStack.