Removing thor version requirement allows rails 6 to bundle #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider merging @laserlemon |
|
I just ran into this, and this gets it bundling again. Rails 6 needs thor 1.0. |
|
For Fsake, can someone merge this and release a new version of Figaro? Firago also conflicts with Solargraph which depends on thor version 1.0. |
|
It tuned out this did happen here: e932bbe#diff-a28aa17ca50fb416dc54a8cda81f3873ed94d950397c5f094b0fa944939c646eR14 So gem version 1.2.0 of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick hack. Probably not the best fix but it allows rails 6 to bundle and seems to be working properly now