Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossorigin anonymus to the mix configuration because it's not possible to use with a CDN for all the resources #1468 #1470

Closed
wants to merge 1 commit into from

Conversation

dantes4ur
Copy link

Fixing #1468 and this is a small fix to enable the telescope to serve from CDN, very useful for distributing public folder into S3/Cloudfront

… missing in the layout

Fixing laravel#1468 and this is a small fix to enable the telescope to serve from CDN, very useful for
distributing public folder into S3/Cloudfront

fix laravel#1468
@taylorotwell
Copy link
Member

A comment on that issue says you just need to update?

@dantes4ur
Copy link
Author

A comment on that issue says you just need to update?

Hey Taylor! Big fan of your work right here.

Found another error around Vite, discussing on the issue I opened

@jason-nabooki
Copy link

I don't think this is required since 5.0.2 was reverted? We're serving our telescope assets (5.0.3) from a CDN (Cloudfront) just fine without the attribute.

We did, however, run into issues with 5.0.2 when there was an integrity attribute added (#1461). The crossorigin="anonymous" would have helped there but for 5.0.3 there shouldn't be any issues?

@dantes4ur
Copy link
Author

I don't think this is required since 5.0.2 was reverted? We're serving our telescope assets (5.0.3) from a CDN (Cloudfront) just fine without the attribute.

We did, however, run into issues with 5.0.2 when there was an integrity attribute added (#1461). The crossorigin="anonymous" would have helped there but for 5.0.3 there shouldn't be any issues?

As I pointed out here #1468 (comment) I found issues with Vite on version 5.0.3, what would be a workaround?

@dantes4ur dantes4ur closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants