Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: assertType calls #1921

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Apr 17, 2024

Hello!

This PR goes through and refactors all the assertType tests for consistency in the codebase:

  • all assertType calls are now inside a function instead of in the top level
  • the name for all these functions is test, I felt this was a better representation of what it actually is for than foo/dummy
    • where it makes sense, some calls are inside a test<Description> method
  • any types needed inside the function are passed as parameters

Thanks!

@canvural canvural merged commit 5abad8a into larastan:2.x May 24, 2024
31 of 35 checks passed
@canvural
Copy link
Collaborator

Thank you!

@calebdw calebdw deleted the refactor_assertTypes branch May 24, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants