Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type inference surrounding Arr::get and Arr::pull. #1858

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Improve type inference surrounding Arr::get and Arr::pull. #1858

wants to merge 1 commit into from

Conversation

mad-briller
Copy link
Contributor

Changes

Improves type inference surrounding Arr::get and Arr::pull, such as return types and type-specifying the Arr::pull $array argument.

Also provides a rule to alert when the $key is not present on the $array for both Arr::get and Arr::pull, closing: #1727

@mad-briller mad-briller force-pushed the arr-get-pull branch 5 times, most recently from c6d399c to a76d517 Compare February 15, 2024 19:17
canvural
canvural requested changes Feb 20, 2024
View reviewed changes
src/Rules/ArrGetPullRule.php Outdated Show resolved Hide resolved
tests/Rules/data/arr-get-pull.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdw calebdw calebdw left review comments

@canvural canvural canvural requested changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mad-briller @szepeviktor @canvural @calebdw