Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/terminal-background #2786

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

evnct
Copy link
Contributor

@evnct evnct commented Nov 14, 2023

@dzhou121
Copy link
Collaborator

panel items don't have backgrounds set including terminal so that when they are at the bottom, they will be the same as editor background. So if you drag the terminal panel to the right or left, it will have the panel background.

@evnct
Copy link
Contributor Author

evnct commented Nov 14, 2023

You mean like this (dragging it to the right)?

Screenshot from 2023-11-14 23-36-37

@dzhou121
Copy link
Collaborator

Yes.

terminal.background probably shouldn't be there to confuse people.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9bddebd) 14.61% compared to head (529a28d) 11.77%.

❗ Current head 529a28d differs from pull request most recent head 9a09cf0. Consider uploading reports for the commit 9a09cf0 to get more accurate results

Files Patch % Lines
lapce-app/src/panel/terminal_view.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2786      +/-   ##
==========================================
- Coverage   14.61%   11.77%   -2.85%     
==========================================
  Files         143      141       -2     
  Lines       52340    47010    -5330     
==========================================
- Hits         7651     5534    -2117     
+ Misses      44689    41476    -3213     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants