Don't perform full syntax update on edit #2318
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only perform a partial scan of the syntax and update the old one instead of replacing it entirely.
This will help a lot with editing large files.
There's an issue with this method however when dealing with syntax changes that are very big.
For example, commenting out a huge block of code will not trigger a syntax update for the block of code.
So there needs to be a better way to figure out which section of the code needs to be updated.
Alternative solutions:
Similar optimization is also possible here https://github.com/lapce/lapce/blob/master/lapce-core/src/syntax/mod.rs#L280
The cursor will currently walk the entire syntax tree instead of only the relevant changes.
CHANGELOG.md
if this change could be valuable to users