Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hook dependency #4242

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

TinsFox
Copy link
Contributor

@TinsFox TinsFox commented May 10, 2024

Description

Fix dependency issues in react-hook

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

How Has This Been Tested?

This logic will only be executed when an error occurs in Google login

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file ☕️ typescript Pull request that update TypeScript code. labels May 10, 2024
@takatost takatost requested a review from nite-knite May 10, 2024 06:47
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 10, 2024
@crazywoola crazywoola merged commit 00ce372 into langgenius:main May 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants