Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: code upgrade #4231

Merged
merged 25 commits into from
May 13, 2024
Merged

improve: code upgrade #4231

merged 25 commits into from
May 13, 2024

Conversation

Yeuoly
Copy link
Collaborator

@Yeuoly Yeuoly commented May 9, 2024

Description

Support Dependenices

image

Support Networking

image

Others

  • Remove SYS_ADMIN permission
  • Support install custom python dependencies

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 9, 2024
@Yeuoly Yeuoly marked this pull request as draft May 9, 2024 16:27
@dosubot dosubot bot added dependencies Pull requests that update a dependency file ☕️ javascript Pull requests that update Javascript code 🐍 python Pull requests that update Python code 💪 enhancement New feature or request labels May 9, 2024
@Yeuoly Yeuoly marked this pull request as ready for review May 11, 2024 11:28
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 11, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 13, 2024
@Yeuoly Yeuoly merged commit bbef964 into main May 13, 2024
15 checks passed
@Yeuoly Yeuoly deleted the feat/code-upgrade branch May 13, 2024 06:39
@takatost takatost mentioned this pull request May 13, 2024
@Clint-chan
Copy link

how can i install my dependencies?

@1992leiting
Copy link

how can i install my dependencies?

I guess it should be in the docker container of docker-sandbox. I just checked pip list in the container and httpx, jinja2 are alreay there.

@Yeuoly
Copy link
Collaborator Author

Yeuoly commented May 14, 2024

Just add them into sandbox/dependencies/python-requirements.txt, but not all dependencies could work as expected while testing, just try it carefully I'll solve them in months.

@Clint-chan
Copy link

Just add them into sandbox/dependencies/python-requirements.txt, but not all dependencies could work as expected while testing, just try it carefully I'll solve them in months.

Great job!

@Clint-chan
Copy link

hope to support libraries like pandas and numpy as soon as possible to give AI workflows the ability to process data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 💪 enhancement New feature or request ☕️ javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer 🐍 python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants