Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require max-attempts to be at least 1 #995

Closed
wants to merge 1 commit into from
Closed

Require max-attempts to be at least 1 #995

wants to merge 1 commit into from
+3 −0

Conversation

jmartisk
Copy link
Contributor

See quarkiverse/quarkus-langchain4j#482 for the related discussion

@langchain4j
Copy link
Owner

Hi @jmartisk thanks a lot!
There is #981 already

@jmartisk
Copy link
Contributor Author

Ok I've commented on that one too, it is slightly different, I'll let you decide what's better, and then just close the other one :)

@langchain4j langchain4j added the P2 High priority label Apr 23, 2024
@geoand
Copy link
Contributor

geoand commented May 10, 2024

As #981 was merged, should this be closed?

@jmartisk
Copy link
Contributor Author

yeah

@jmartisk jmartisk closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
P2 High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmartisk @langchain4j @geoand