Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge OpenAiStreamingChatModel and OpenAiChatModel classes #971

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

anunnakian
Copy link

@anunnakian anunnakian commented Apr 18, 2024

Context

This PR fix the issue #954

Change

  • I merged the ChatLanguageModel and StreamingChatLanguageModel classes
  • I removed the StreamingChatLanguageModel class
  • I removed the OpenAiStreamingChatModelBuilderFactory class

Checklist

Before submitting this PR, please check the following points:

  • I have added unit and integration tests for my change
  • All unit and integration tests in the module I have added/changed are green
  • All unit and integration tests in the core and main modules are green
  • I have added/updated the documentation
  • I have added an example in the examples repo (only for "big" features)
  • I have added my new module in the BOM (only when a new module is added)

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT

@anunnakian anunnakian force-pushed the remove_OpenAiStreamingChatModel branch from 12d7e82 to b7c85e3 Compare April 20, 2024 21:57
… into remove_OpenAiStreamingChatModel

# Conflicts:
#	langchain4j-open-ai/src/main/java/dev/langchain4j/model/openai/OpenAiChatModel.java
@langchain4j langchain4j added P3 Medium priority P2 High priority labels Apr 23, 2024
@anunnakian
Copy link
Author

Hello @LizeRaes, here is my PR that I made during the Devoxx session, please take a look when you have time 🤓

@anunnakian anunnakian changed the title Avoid using OpenAiStreamingChatModel class Merge OpenAiStreamingChatModel and OpenAiChatModel classes Apr 27, 2024
@LizeRaes
Copy link
Collaborator

Thanks a lot @anunnakian , nice for streamlining experience! Looking forward to the minor fixes and getting it merged :)

@anunnakian anunnakian force-pushed the remove_OpenAiStreamingChatModel branch 2 times, most recently from 37ad3d5 to 32748b9 Compare May 1, 2024 10:47
@anunnakian anunnakian force-pushed the remove_OpenAiStreamingChatModel branch from 32748b9 to 0a0ac22 Compare May 1, 2024 10:48
@anunnakian
Copy link
Author

Thanks a lot @anunnakian , nice for streamlining experience! Looking forward to the minor fixes and getting it merged :)

Minor changes done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 High priority P3 Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants