addOptionalParameter for aiServices #922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhangdashuai11 please add tests and document this change. Please see https://github.com/langchain4j/langchain4j/blob/main/CONTRIBUTING.md |
langchain4j
requested changes
Apr 18, 2024
| //if user define method parameter as Optional addOptionalParameter | ||
| if (parameter.getType().equals(Optional.class)) { | ||
| builder.addOptionalParameter(parameter.getName(), toJsonSchemaProperties(parameter)); | ||
| } | ||
| builder.addParameter(parameter.getName(), toJsonSchemaProperties(parameter)); |
There was a problem hiding this comment.
This should probybly be in else block.
| @@ -56,6 +57,10 @@ public static ToolSpecification toolSpecificationFrom(Method method) { | |||
| if (parameter.isAnnotationPresent(ToolMemoryId.class)) { | |||
| continue; | |||
| } | |||
| //if user define method parameter as Optional addOptionalParameter | |||
| if (parameter.getType().equals(Optional.class)) { | |||
| builder.addOptionalParameter(parameter.getName(), toJsonSchemaProperties(parameter)); | |||
There was a problem hiding this comment.
toJsonSchemaProperties will receive Optional type, but should probably receive an actual type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when use tools if user define method parameter as Optional addOptionalParameter