Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: LLM Observability #1058

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Draft: LLM Observability #1058

wants to merge 6 commits into from

Conversation

langchain4j
Copy link
Owner

@langchain4j langchain4j commented May 7, 2024

Issue

#199

Change

  • Added ChatLanguageModelListener, ChatLanguageModelRequest, and ChatLanguageModelResponse that are compatible (have all the required attributes) with OTEL LLM semconv draft.
  • Added an option to attach ChatLanguageModelListener to OpenAiChatModel and OpenAiStreamingChatModel (pilot module)

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green
  • I have added/updated the documentation
  • I have added an example in the examples repo (only for "big" features)

@langchain4j
Copy link
Owner Author

langchain4j commented May 7, 2024

@brunobat could you please take a look? 🙏

@geoand
Copy link
Contributor

geoand commented May 13, 2024

I'm also very interested in this so we can augment in the already present observability features in the Quarkus implementation.

I also think that having something like this in sooner that rather than later would be very helpful as these new integration points could definitely prove useful for various tasks.

@geoand
Copy link
Contributor

geoand commented May 13, 2024

I believe that onResponse could also be passed ChatLanguageModelRequest

@langchain4j
Copy link
Owner Author

@geoand yeah I was just adding it :)

@geoand
Copy link
Contributor

geoand commented May 13, 2024

💪🏼

@langchain4j
Copy link
Owner Author

langchain4j commented May 13, 2024

@geoand do you think id can still be useful for something (after adding request to onResponse())?

@geoand
Copy link
Contributor

geoand commented May 13, 2024

I very much doubt it's useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants