Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PgVectorEmbeddingStore: remove by ID #1020

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nottyjay
Copy link

Change

Add search method in PgVectorEmbeddingStore
Add remove data method in the interface of EmbeddingStore
Add remove data method in PgVectorEmbeddingStore

Checklist

  • I have added unit and integration tests for my change
  • All unit and integration tests in the module I have added/changed are green
  • All unit and integration tests in the core and main modules are green

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT

@nottyjay
Copy link
Author

@langchain4j
Add remove method to delete embedding data which stored in vector store.
Add search in PgVectorEmbeddingStore
I checked locally everything compiles and tests pass.

@langchain4j
Copy link
Owner

@nottyjay thanks a lot!
Please revert changes of formatting, it is imposible to review right now :(

@langchain4j langchain4j changed the title Embedding store PgVectorEmbeddingStore: remove by ID Apr 29, 2024
@langchain4j
Copy link
Owner

Related issue: #301

@langchain4j langchain4j added the P2 High priority label Apr 29, 2024
@humcqc
Copy link
Contributor

humcqc commented Apr 29, 2024

Hi @langchain4j , @nottyjay perhaps this should be done after #851 to avoid more conflicts.
@nottyjay perhaps you could implement it on top of this PR, or I can do it quickly after we merge #851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants