Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split AstraDB and Cassandra Stores #1014

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

clun
Copy link
Collaborator

@clun clun commented Apr 24, 2024

Context

AstraDB expose a mongo-like api different from the low level CQL (Cassandra Query Language). It is still possible to use the CassandraEmbeddingStore but the Astra DB layer offer richer filters capabilities matchin criteria from langchain4j.

Change

Split Cassandra and AstraDB, implementing now AstraDB Store, Adding more tests.

Checklist

Before submitting this PR, please check the following points:

  • I have added unit and integration tests for my change
  • All unit and integration tests in the module I have added/changed are green
  • All unit and integration tests in the core and main modules are green
  • I have added/updated the documentation
  • I have added an example in the examples repo (only for "big" features) You can find the associate PR HERE
  • I have added my new module in the BOM (only when a new module is added)

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT

@clun clun added the draft label Apr 24, 2024
@clun clun removed the draft label Apr 25, 2024
@clun clun requested a review from LizeRaes April 25, 2024 19:29
@langchain4j langchain4j added the P3 Medium priority label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants