Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure OpenAI and AI Search #8

Merged
merged 53 commits into from
May 2, 2024
Merged

Conversation

showpune
Copy link
Contributor

@showpune showpune commented Feb 18, 2024

Add starter for
Azure Open AI, include

  1. AzureOpenAiChatModel
  2. AzureOpenAiStreamingChatModel
  3. AzureOpenAiEmbeddingModel
  4. AzureOpenAiImageModel
    Add support for AI Search ( dependen on PR AzureAiSearchEmbeddingStore: Enable build the store without updating the index langchain4j#758)

Need the env

AZURE_OPENAI_KEY
AZURE_OPENAI_ENDPOINT
AZURE_OPENAI_DEPLOYMENT_NAME
AZURE_EMBEDDING_DEPLOYMENT_NAME
AZURE_AISEARCH_API_KEY
AZURE_AISEARCH_ENDPOINT
AZURE_AISEARCH_SETUP_INDEX
AZURE_AISEARCH_DIMENSIONS

To run the IT

Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@showpune thanks a lot!

@showpune showpune changed the title Support Azure OpenAI Support Azure OpenAI and AI Search Mar 15, 2024
@showpune
Copy link
Contributor Author

Spring don't support or condition, I updated the code using other solution

@showpune showpune requested a review from jdubois March 28, 2024 07:08
Copy link

@jdubois jdubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sad that you need to have both configurations, but indeed that's the only way to have this working.
And 99,99% of people will use "API Key", and this configuration is the most logical and easiest for them.

Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@showpune thanks a lot!

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
langchain4j-azure-aisearch-spring-boot-starter/pom.xml Outdated Show resolved Hide resolved
langchain4j-azure-aisearch-spring-boot-starter/pom.xml Outdated Show resolved Hide resolved
langchain4j-azure-aisearch-spring-boot-starter/pom.xml Outdated Show resolved Hide resolved
langchain4j-azure-openai-spring-boot-starter/pom.xml Outdated Show resolved Hide resolved
langchain4j-azure-openai-spring-boot-starter/pom.xml Outdated Show resolved Hide resolved
@showpune
Copy link
Contributor Author

@langchain4j , can you help to approve if no more comments?

@showpune
Copy link
Contributor Author

@jdubois, can you help to approve my PR?

@showpune
Copy link
Contributor Author

@langchain4j , can you help to check?

@langchain4j
Copy link
Owner

@showpune sure, sorry for delays, I have too much on my plate right now

@langchain4j langchain4j merged commit 2b95082 into langchain4j:main May 2, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants