Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Compile more tutorials #193

Merged
merged 3 commits into from
May 30, 2024
Merged

[Docs] Compile more tutorials #193

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07907fb
who developed this package ecosystem anyway
hinthornw May 30, 2024
0525919
do we really have to list every single noteobok as a dev dep
hinthornw May 30, 2024
0fb7b32
fmt
hinthornw May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _scripts/run_notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def compile_ts_code(ts_code: str, tsconfig_options: list) -> str:
temp_file_path = "temp.ts"
with open(temp_file_path, "w") as f:
f.write(ts_code)
cmd = ["npx", "tsc", temp_file_path] + tsconfig_options
cmd = ["npx", "tsc", temp_file_path] + tsconfig_options + ["--skipLibCheck"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so it stops raising errors when i import cheerio ; maybe something to do with esm module vs nodenext vs idc

try:
result = subprocess.run(cmd, capture_output=True, text=True, check=True)
stdout = result.stdout
Expand Down
Loading
Loading