[Docs] Run TSC on HOWTOs + README #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
changed the title
nfcampos
reviewed
May 30, 2024
| temp_file_path = "temp.ts" | ||
| with open(temp_file_path, "w") as f: | ||
| f.write(ts_code) | ||
| cmd = ["npx", "tsc", temp_file_path] + tsconfig_options |
There was a problem hiding this comment.
Can't you just pass the config file to tsc?
There was a problem hiding this comment.
You would think. Maybe you can. Doesn't seem like it though.
When input files are specified on the command line, tsconfig.json files are ignored.
Maybe through something like --project
Ah no still not:
error TS5042: Option 'project' cannot be mixed with source files on a command line.
| def run_js_code(js_code_path: str) -> str: | ||
| print("Running JavaScript code...") | ||
| process = subprocess.Popen( | ||
| ["npx", "node", js_code_path], |
There was a problem hiding this comment.
Because i have no clue what i'm doing but tsc doesn't run but npx tsc does locally for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.