Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[minor]: Add Google Routes Tool #5329

Merged
merged 23 commits into from May 20, 2024
Merged

Conversation

Luisotee
Copy link
Contributor

This PR attempts to add a Google Routes Tool. The tool can help your agent calculate routes between places by car, motorcycle, transit, bike, and on foot. It can provide information such as tolls fare, transit fare, transit line, a short description of the route, possible problems along the route, etc.

I am open to any comments and suggestions regarding this merge request. I value your time and am willing to make the necessary changes to expedite its acceptance into the main branch, as I consider these tools a valuable addition to the TS version of the community toolset.

Thank you for the opportunity to contribute to the project!

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 10, 2024
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 6:33pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 20, 2024 6:33pm

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label May 10, 2024
@@ -0,0 +1,424 @@
import { StructuredTool } from "@langchain/core/tools";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just wanted to flag that this PR introduces a new HTTP request using the fetch API to the Google Routes API endpoint. This comment is to bring attention to this change for review. Great work on the implementation!

@@ -0,0 +1,424 @@
import { StructuredTool } from "@langchain/core/tools";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, I've reviewed the code changes and flagged a question regarding the usage of environment variables via getEnvironmentVariable and the fetch request. Please take a look to ensure the proper handling and security of environment variables.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 16, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels May 16, 2024
@Luisotee Luisotee closed this May 16, 2024
@Luisotee Luisotee reopened this May 16, 2024
@jacoblee93
Copy link
Collaborator

Hey @Luisotee, apologies for the delay! I was on vacation, then this week we had a small freeze for 0.2.0.

This looks fantastic and well thought out though, having a deeper look now

@Luisotee
Copy link
Contributor Author

@jacoblee93 Don't worry, and thank you for reviewing my PR!

@jacoblee93 jacoblee93 merged commit 351a34e into langchain-ai:main May 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants