Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: support alibaba_tongyi stream output #5271

Merged
merged 3 commits into from May 14, 2024

Conversation

sinajia
Copy link
Contributor

@sinajia sinajia commented May 2, 2024

Fixes # (issue)

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:15pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 8, 2024 2:15pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels May 2, 2024
@@ -493,6 +496,109 @@ export class ChatAlibabaTongyi
return this.caller.call(makeCompletionRequest);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the new code introduces a net-new HTTP request using the fetch method. I've flagged this for your review to ensure it aligns with the project's architecture and requirements. Let me know if you have any questions or need further clarification!

Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you add a test too? Thanks for doing this!

@sinajia
Copy link
Contributor Author

sinajia commented May 8, 2024

fix type error, add a test

@jacoblee93 jacoblee93 merged commit e35aef9 into langchain-ai:main May 14, 2024
17 checks passed
@jacoblee93
Copy link
Collaborator

Thank you! This will be released in about a week along with 0.2 - let me know if you need it cherry picked sooner.

@jacoblee93 jacoblee93 changed the title support alibaba_tongyi stream output community[patch]: support alibaba_tongyi stream output May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants