community[minor]: Add Moonshot chat models integration #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XL
crazyurus
force-pushed
the
main
branch
2 times, most recently
from
d1e08af
to
7eb8ea0
Compare
jacoblee93
reviewed
May 13, 2024
jacoblee93
reviewed
May 13, 2024
jacoblee93
reviewed
May 13, 2024
|
|
||
| moonshotApiKey?: string; | ||
|
|
||
| apiKey?: string; |
There was a problem hiding this comment.
Why two different variables?
There was a problem hiding this comment.
Because I saw that some model parameters in langchain provide this alias name apiKey(such as baiduwenxin zhipuai minimax), and some do not(such as alibabatongyi), so retained here.
There was a problem hiding this comment.
Let's just use apiKey - we're trying to standardize parameter names more.
jacoblee93
reviewed
May 20, 2024
| } | ||
|
|
||
| _llmType(): string { | ||
| return "Moonshot"; |
|
Hey, I'm very sorry for the delay - I was on vacation and then we had a lot to do for the launch of 0.2.0. Small comments but looks good otherwise! I can update this tomorrow unless you beat me to it. |
jacoblee93
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moonshot is a Chinese startup that provides LLM service for companies and individuals. See https://platform.moonshot.cn/docs/intro.
Langchain Python already has Moonshot integration. See https://python.langchain.com/docs/integrations/chat/moonshot/
So complete this integration in the Javascript version