Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch],weaviate[patch]: types: the args of the WeaviateFilter is optional #5193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

community[patch],weaviate[patch]: types: the args of the WeaviateFilter is optional #5193

wants to merge 2 commits into from
+3 −3

Conversation

hehuangz
Copy link

Fixes # (issue)

it's not necessary pass distance and where condition at the same time

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 24, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 7:16am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 25, 2024 7:16am

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Apr 24, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 changed the title types: the args of where is optional in WeaviateFilter community[patch],weaviate[patch]: types: the args of where is optional in WeaviateFilter Apr 24, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Apr 24, 2024
@jacoblee93
Copy link
Collaborator

Seems it's failing build - can you have a look?

@hehuangz hehuangz changed the title community[patch],weaviate[patch]: types: the args of where is optional in WeaviateFilter community[patch],weaviate[patch]: types: the args of WeaviateFilter is optional Apr 25, 2024
@hehuangz hehuangz changed the title community[patch],weaviate[patch]: types: the args of WeaviateFilter is optional community[patch],weaviate[patch]: types: the args of the WeaviateFilter is optional Apr 25, 2024
@hehuangz
Copy link
Author

Seems it's failing build - can you have a look?

ok

@hehuangz
Copy link
Author

Seems it's failing build - can you have a look?

Hi, I don't have a better way to revise it, please check if it works, thanks!

bracesproul
bracesproul previously requested changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismiss this

@dosubot dosubot bot removed the lgtm PRs that are ready to be merged as-is label Apr 26, 2024
@jacoblee93
Copy link
Collaborator

Getting:

Error: @langchain/weaviate:build: src/vectorstores.ts(243,20): error TS2345: Argument of type '{ operands?: ...[] | undefined; operator?: "And" | "Or" | "Equal" | "Like" | "NotEqual" | "GreaterThan" | "GreaterThanEqual" | "LessThan" | "LessThanEqual" | "WithinGeoRange" | "IsNull" | "ContainsAny" | "ContainsAll" | undefined; ... 13 more ...; valueGeoRange?: { ...; } | undefined; } | undefined' is not assignable to parameter of type '{ operands?: ...[] | undefined; operator?: "And" | "Or" | "Equal" | "Like" | "NotEqual" | "GreaterThan" | "GreaterThanEqual" | "LessThan" | "LessThanEqual" | "WithinGeoRange" | "IsNull" | "ContainsAny" | "ContainsAll" | undefined; ... 13 more ...; valueGeoRange?: { ...; } | undefined; }'.

On CI build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul left review comments

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hehuangz @jacoblee93 @bracesproul