feat: Remove dependency with uuid-ossp extension #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PostgreSQL 13, the gen_random_uuid() function has reached the core. The uuid-ossp extension, providing the uuid_generate_v4() function, can be removed. Signed-off-by: Julien Riou <[email protected]>
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
|
Hey @jouir, thanks for the PR! Is there a performance hit to using the extension? If not, then I would much prefer to wait for EOL before merging. |
|
Hello @jacoblee93, There is no performance impact if the extension is used instead of the core function. The PR intent is to remove dependency with an extension and only rely on the core features of PostgreSQL. But using the extension until PostgreSQL 12 is not supported is fine. |
|
Yes, let's leave it for now then. Will revisit when EOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PostgreSQL 13, the gen_random_uuid() function has reached the core. The uuid-ossp extension, providing the uuid_generate_v4() function, can be removed.
This is a breaking change for PostgreSQL 12 which will be maintained until November 14, 2024. An improvement would be to issue
show server_version_num;query and use gen_random_uuid() if the result is higher or equal than 130000 or uuid_generate_v4(). Unfortunately, my Javascript skills are pretty limited so help would be appreciated.References: