Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[minor]: feat: Layerup Security integration #4929

Merged
merged 19 commits into from May 21, 2024
Merged

community[minor]: feat: Layerup Security integration #4929

merged 19 commits into from May 21, 2024

Conversation

JamsheedMistri
Copy link
Contributor

@JamsheedMistri JamsheedMistri commented Mar 30, 2024 •
edited

Description: adds integration with Layerup Security. Docs can be found here. Integrates directly with our TypeScript SDK.

Note: all methods for our product require a paid API key, so I only included 1 test which checks for an invalid API key response. I have tested extensively locally.

Twitter handle: @layerup_

@vercel Vercel
Copy link

vercel bot commented Mar 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 0:23am
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 21, 2024 0:23am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Mar 30, 2024
@jacoblee93
Copy link
Collaborator

Thanks, see comments and don't forget to run yarn format + yarn lint

@jacoblee93 jacoblee93 added the close PRs that need one or two touch-ups to be ready label Apr 3, 2024
@jacoblee93 jacoblee93 changed the title feat: Layerup Security integration community[patch]: feat: Layerup Security integration Apr 3, 2024
@jacoblee93 jacoblee93 changed the title community[patch]: feat: Layerup Security integration community[minor]: feat: Layerup Security integration Apr 3, 2024
@jacoblee93
Copy link
Collaborator

Thanks for your patience! Small typing issue, I would fix but I can't make edits here.

@jacoblee93 jacoblee93 added the hold On hold label Apr 11, 2024
@JamsheedMistri
Copy link
Contributor Author

@jacoblee93 Looks like some parts of the repo had the @layerup/layerup-security SDK on version 1.5.6, which had a types import bug for OpenAI. I just bumped the remaining imports from 1.5.6 to 1.5.9 which should fix the issue.

@jacoblee93 jacoblee93 removed the hold On hold label Apr 15, 2024
@jacoblee93
Copy link
Collaborator

Still failing with:

Cannot find module 'openai/resources' or its corresponding type declarations.

You should also run yarn to update the lockfile if you update an SDK version

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit 62275b1 into langchain-ai:main May 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosubot dosubot[bot] dosubot left review comments

@jacoblee93 jacoblee93 Awaiting requested review from jacoblee93

Assignees
No one assigned
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamsheedMistri @jacoblee93