Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: Check if event loop is closed in memory stream #21841

Merged
merged 1 commit into from
May 17, 2024
Merged

core[patch]: Check if event loop is closed in memory stream #21841

merged 1 commit into from
May 17, 2024

Conversation

eyurtsev
Copy link
Collaborator

Check if event stream is closed in memory loop.

Using try/except here to avoid race condition, but this may incur a small
overhead in versions prios to 3.11

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 9:48pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: memory Related to memory module 🤖:improvement Medium size change to existing code to handle new use-cases labels May 17, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 17, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) May 17, 2024 21:53
@eyurtsev eyurtsev merged commit 67b6f6c into master May 17, 2024
96 checks passed
@eyurtsev eyurtsev deleted the eugene/add_check_close branch May 17, 2024 21:54
jeromechoo pushed a commit to jeromechoo/langchain that referenced this pull request May 20, 2024
@eyurtsev
core[patch]: Check if event loop is closed in memory stream (langchai…
e60e6a6 
…n-ai#21841)

Check if event stream is closed in memory loop.

Using try/except here to avoid race condition, but this may incur a
small overhead in versions prios to 3.11
JuHyung-Son pushed a commit to JuHyung-Son/langchain that referenced this pull request May 23, 2024
@eyurtsev @JuHyung-Son
core[patch]: Check if event loop is closed in memory stream (langchai…
e23a197 
…n-ai#21841)

Check if event stream is closed in memory loop.

Using try/except here to avoid race condition, but this may incur a
small overhead in versions prios to 3.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfcampos nfcampos nfcampos approved these changes

Assignees

@nfcampos nfcampos

Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: memory Related to memory module size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eyurtsev @nfcampos