-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Skip Login to HuggubgFaceHub when token is not set #21561
base: master
Are you sure you want to change the base?
community: Skip Login to HuggubgFaceHub when token is not set #21561
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
it is necessary function !! |
Mentioning @mspronesti and @hwchase17 since you were the reviewers on my other HuggingFace PR #21282 |
libs/community/langchain_community/llms/huggingface_endpoint.py
Outdated
Show resolved
Hide resolved
…skip_login' into feature/HuggingFaceEndpoint_hfhub_skip_login # Conflicts: # libs/community/langchain_community/llms/huggingface_endpoint.py
There is a new official library released from Huggning Face Here is the deprecation warning when using the current community library.
|
The current library is not deprecated yet and it looks like it will be around for quite some time. We can make this change also in the new |
@mirkenstein Any reason to not just bundle that change into this PR as well? Would help keep the change unified across both clients, easier to track down the original PR, etc |
One of the guidelines states that "Most PRs should not touch more than one package" |
Created #22365 for the new partner client. |
Thank you for contributing to LangChain!
HuggingFaceEndpoint: "Skip Login to HuggingFaceHub"
PR message: Delete this entire checklist and replace with
huggingfacehub_api_token
is not set. This is needed when using customendpoint_url
outside of HuggingFaceHub.Add tests and docs:
Also tested against HF Endpoints
Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.