Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update Elasticsearch strategy names #21530

Merged
merged 3 commits into from
May 17, 2024
Merged

docs: update Elasticsearch strategy names #21530

merged 3 commits into from
May 17, 2024

Conversation

maxjakob
Copy link
Contributor

Update documentation with the new names for retrieval strategies

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 10, 2024
@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 11:21pm

@dosubot dosubot bot added 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels May 10, 2024
@maxjakob
Copy link
Contributor Author

@joemcelroy @efriis

joemcelroy
joemcelroy reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@joemcelroy joemcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loks good so far!

The FAQ still have a couple examples using the old ExactRetrievalStrategy / Sparse Retrieval name

@maxjakob maxjakob requested a review from joemcelroy May 13, 2024 13:26
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 17, 2024
@efriis efriis enabled auto-merge (squash) May 17, 2024 23:15
@efriis efriis merged commit e6b7a17 into langchain-ai:master May 17, 2024
12 checks passed
jeromechoo pushed a commit to jeromechoo/langchain that referenced this pull request May 20, 2024
@maxjakob @efriis
docs: update Elasticsearch strategy names (langchain-ai#21530)
1c21bca 
Update documentation with the [new names for retrieval
strategies](langchain-ai/langchain-elastic#22)

---------

Co-authored-by: Erick Friis <[email protected]>
JuHyung-Son pushed a commit to JuHyung-Son/langchain that referenced this pull request May 23, 2024
@maxjakob @efriis @JuHyung-Son
docs: update Elasticsearch strategy names (langchain-ai#21530)
06d34ea 
Update documentation with the [new names for retrieval
strategies](langchain-ai/langchain-elastic#22)

---------

Co-authored-by: Erick Friis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

@efriis efriis efriis approved these changes

Assignees
No one assigned
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxjakob @joemcelroy @efriis