community: Chroma Adding create_collection_if_not_exists flag to Chroma constructor #21420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to either get_or_create or simply get collection. This is useful when dealing wit read-only Chroma instances where users can only get_collection. Targeted at Http/CloudClients mostly. Closes chroma-core/chroma#2163
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
ccurme
reviewed
May 8, 2024
ccurme
approved these changes
May 8, 2024
dosubot
bot
added
the
lgtm
|
@ccurme, I've added truth table with test case mapping in description to make it a little easier to understand |
ccurme
approved these changes
May 9, 2024
Narapady
pushed a commit
to Narapady/langchain
that referenced
this pull request
May 9, 2024
…ma constructor (langchain-ai#21420) - **Description:** Adds the ability to either `get_or_create` or simply `get_collection`. This is useful when dealing with read-only Chroma instances where users are constraint to using `get_collection`. Targeted at Http/CloudClients mostly. - **Issue:** chroma-core/chroma#2163 - **Dependencies:** N/A - **Twitter handle:** `@t_azarov` | Collection Exists | create_collection_if_not_exists | Outcome | test | |-------------------|---------------------------------|----------------------------------------------------------------|----------------------------------------------------------| | True | False | No errors, collection state unchanged | `test_create_collection_if_not_exist_false_existing` | | True | True | No errors, collection state unchanged | `test_create_collection_if_not_exist_true_existing` | | False | False | Error, `get_collection()` fails | `test_create_collection_if_not_exist_false_non_existing` | | False | True | No errors, `get_or_create_collection()` creates the collection | `test_create_collection_if_not_exist_true_non_existing` |
kyle-cassidy
pushed a commit
to kyle-cassidy/langchain
that referenced
this pull request
May 10, 2024
…ma constructor (langchain-ai#21420) - **Description:** Adds the ability to either `get_or_create` or simply `get_collection`. This is useful when dealing with read-only Chroma instances where users are constraint to using `get_collection`. Targeted at Http/CloudClients mostly. - **Issue:** chroma-core/chroma#2163 - **Dependencies:** N/A - **Twitter handle:** `@t_azarov` | Collection Exists | create_collection_if_not_exists | Outcome | test | |-------------------|---------------------------------|----------------------------------------------------------------|----------------------------------------------------------| | True | False | No errors, collection state unchanged | `test_create_collection_if_not_exist_false_existing` | | True | True | No errors, collection state unchanged | `test_create_collection_if_not_exist_true_existing` | | False | False | Error, `get_collection()` fails | `test_create_collection_if_not_exist_false_non_existing` | | False | True | No errors, `get_or_create_collection()` creates the collection | `test_create_collection_if_not_exist_true_non_existing` |
|
@efriis We are taking dependency on langchain-chroma and have to publish a package to pypi that needs this change. Can we expedite the next release of this partner package to pypi ? When is the planned release ? |
kyle-cassidy
pushed a commit
to kyle-cassidy/langchain
that referenced
this pull request
May 16, 2024
…ma constructor (langchain-ai#21420) - **Description:** Adds the ability to either `get_or_create` or simply `get_collection`. This is useful when dealing with read-only Chroma instances where users are constraint to using `get_collection`. Targeted at Http/CloudClients mostly. - **Issue:** chroma-core/chroma#2163 - **Dependencies:** N/A - **Twitter handle:** `@t_azarov` | Collection Exists | create_collection_if_not_exists | Outcome | test | |-------------------|---------------------------------|----------------------------------------------------------------|----------------------------------------------------------| | True | False | No errors, collection state unchanged | `test_create_collection_if_not_exist_false_existing` | | True | True | No errors, collection state unchanged | `test_create_collection_if_not_exist_true_existing` | | False | False | Error, `get_collection()` fails | `test_create_collection_if_not_exist_false_non_existing` | | False | True | No errors, `get_or_create_collection()` creates the collection | `test_create_collection_if_not_exist_true_non_existing` |
|
@harshal-cuminai langchain-chroma 0.1.1 was released yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_or_createor simplyget_collection. This is useful when dealing with read-only Chroma instances where users are constraint to usingget_collection. Targeted at Http/CloudClients mostly.@t_azarovtest_create_collection_if_not_exist_false_existingtest_create_collection_if_not_exist_true_existingget_collection()failstest_create_collection_if_not_exist_false_non_existingget_or_create_collection()creates the collectiontest_create_collection_if_not_exist_true_non_existing