langchain[patch],community[minor]: Move some unit tests from langchain to community, use core for fake models #21190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
size:XS
eyurtsev
commented
May 2, 2024
| @@ -6,7 +6,6 @@ set -eu | |||
| errors=0 | |||
|
|
|||
| # make sure not importing from langchain or langchain_experimental | |||
| git --no-pager grep '^from langchain\.' . && errors=$((errors+1)) | |||
There was a problem hiding this comment.
Adjusting this lint rule in preparation for flipping the dependency between community and langchain
community will be allowed to dependent on langchain
but langchain will no longer be allowed to dependent on community
dosubot
bot
added
Ɑ: retriever
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates in some tests