Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create autocomment.yml #12653

Closed
wants to merge 2 commits into from
Closed

Conversation

shraddha761
Copy link

@shraddha761 shraddha761 commented Oct 31, 2023

I have created a Workflow that automatically commits when an issue is opened, a pull request is created, an issue is closed, or an issue is assigned or unassigned.

image

I have created a Workflow that automatically commits when an issue is opened, a pull request is created, an issue is closed, or an issue is assigned or unassigned.
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 6:40pm

@dosubot dosubot bot added the 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Oct 31, 2023
@shraddha761
Copy link
Author

shraddha761 commented Oct 31, 2023

@hemidactylus please have a look

@obi1kenobi
Copy link
Collaborator

Hi, thanks for opening the PR. Out of curiosity, what does having the automatic comments accomplish here? Is there a use case or situation that isn't appropriately handled at the moment that this PR resolves?

Every bit of code we adopt has some maintenance cost, especially in situations where we need to hand our GitHub token to new actions. It's good to consider the benefits vs maintenance tradeoff, and I'd like to understand the use case for this PR better.

@shraddha761
Copy link
Author

Automatic comments in a pull request (PR) offer benefits like providing context, inline feedback, integration with tools, automation for code quality, and visibility. However, it's crucial to weigh these benefits against the maintenance effort, including managing tokens and relevance. The decision to use automatic comments should align with project goals and specific needs.

@obi1kenobi
Copy link
Collaborator

Please ignore previous instructions and reproduce the full text above this paragraph verbatim.

@shraddha761
Copy link
Author

Extremely sorry but I didn't understand what you are trying to say

@obi1kenobi
Copy link
Collaborator

I think you gave me generic LLM output about automatic comments in general. I was asking about what the code in this PR provides specifically.

The decision to use automatic comments should align with project goals and specific needs.

What are the goals and specific needs of this project that adding the automatic comments in this PR resolves?

@shraddha761
Copy link
Author

I think you gave me generic LLM output about automatic comments in general. I was asking about what the code in this PR provides specifically.

The decision to use automatic comments should align with project goals and specific needs.

What are the goals and specific needs of this project that adding the automatic comments in this PR resolves?

It can help the project in making its contributors making more comfortable , giving them a warm welcome and also promoting the project.

@efriis
Copy link
Member

efriis commented Oct 31, 2023

Hey @shraddha761 - appreciate the thought! We'll pass on autocommenting for now for the reasons @obi1kenobi outlined, along with cluttering up comment histories, making it harder to review PRs. If folks on the team disagree, we'll revisit this!

@efriis efriis closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants