added VertexStringEvaluator #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuligin
force-pushed
the
eval
branch
4 times, most recently
from
43745b7
to
763605d
Compare
alx13
approved these changes
May 23, 2024
eliasecchig
reviewed
May 23, 2024
| client_info=get_client_info(module=self._user_agent), | ||
| ) | ||
| self._location = self._client.common_location_path(project_id, location) | ||
| if _format_metric(metric) not in _METRICS: |
There was a problem hiding this comment.
would this not support custom metric right now ?
There was a problem hiding this comment.
yes, we can add it later
eliasecchig
pushed a commit
to eliasecchig/langchain-google
that referenced
this pull request
May 27, 2024
eliasecchig
pushed a commit
to eliasecchig/langchain-google
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.