Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix tool.lint.ruff in pyproject.toml #239

Merged
merged 2 commits into from
Jun 12, 2024
Merged

chore: fix tool.lint.ruff in pyproject.toml #239

merged 2 commits into from
Jun 12, 2024

Conversation

nobu007
Copy link
Contributor

@nobu007 nobu007 commented May 21, 2024

Fix setting in pyproject.toml.

  • tool.ruff -> tool.lint.ruff
  • ruff version = 0.4.1.

This PR resolve Warnings

result(before).

langchain-google$ ruff formatruff format
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `langchain-google/libs/genai/pyproject.toml`:
  - 'select' -> 'lint.select'
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `langchain-google/libs/community/pyproject.toml`:
  - 'select' -> 'lint.select'
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `langchain-google/libs/vertexai/pyproject.toml`:
  - 'select' -> 'lint.select'
4 files reformatted, 122 files left unchanged

result(before).

langchain-google$ ruff format
52 files reformatted, 74 files left unchanged

lkuligin
lkuligin reviewed May 21, 2024
View reviewed changes
libs/community/pyproject.toml Outdated
@@ -101,7 +101,7 @@ types-requests = "^2.31.0.10"
types-pillow = "^10.1.0.2"
types-google-cloud-ndb = "^2.2.0.1"

[tool.ruff]
[tool.lint.ruff]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be tool.ruff.lint too, or am I missing anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I updated it.

@lkuligin
Copy link
Collaborator

/gcbrun

@nobu007 nobu007 force-pushed the fix_ruff_lint_pyproject_toml branch from 2535289 to c58b5aa Compare June 2, 2024 06:29
@nobu007 nobu007 force-pushed the fix_ruff_lint_pyproject_toml branch from c58b5aa to 5d7556c Compare June 2, 2024 06:32
@lkuligin
Copy link
Collaborator

/gcbrun

@lkuligin
Copy link
Collaborator

/gcbrun

@lkuligin lkuligin merged commit fed1bba into langchain-ai:main Jun 12, 2024
37 of 38 checks passed
eliasecchig pushed a commit to eliasecchig/langchain-google that referenced this pull request Jun 12, 2024
@nobu007 @lkuligin @eliasecchig
chore: fix tool.ruff.lint in pyproject.toml (langchain-ai#239)
b22ef19 
Co-authored-by: Leonid Kuligin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkuligin lkuligin lkuligin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nobu007 @lkuligin